Skip to content

feat(cli,core,utils): replace basic logs with new logger#1138

Merged
matejchalk merged 1 commit intomainfrom
logger-in-core
Nov 10, 2025
Merged

feat(cli,core,utils): replace basic logs with new logger#1138
matejchalk merged 1 commit intomainfrom
logger-in-core

Conversation

@matejchalk
Copy link
Collaborator

@matejchalk matejchalk commented Nov 7, 2025 •
edited
Loading

Part of #888

Replaces basic @poppinss/cliui logs with new logger in the core packages - cli, core, utils.

I'll tackle logs in plugins and the more complex @poppinss/cliui logs (tables, stickers) in other PRs.

@nx-cloud
Copy link

nx-cloud bot commented Nov 7, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit bd99373

Command Status Duration Result
nx code-pushup --nx-bail -- compare ✅ Succeeded 53s View ↗
nx code-pushup --nx-bail -- ✅ Succeeded 1m View ↗
nx code-pushup --nx-bail -- print-config --outp... ✅ Succeeded 3m 46s View ↗

☁️ Nx Cloud last updated this comment at 2025-11-07 15:53:01 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 7, 2025 •
edited
Loading

Open in StackBlitz

@code-pushup/ci

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/ci@1138

@code-pushup/cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/cli@1138

@code-pushup/core

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/core@1138

@code-pushup/create-cli

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/create-cli@1138

@code-pushup/models

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models@1138

@code-pushup/nx-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/nx-plugin@1138

@code-pushup/coverage-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/coverage-plugin@1138

@code-pushup/eslint-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/eslint-plugin@1138

@code-pushup/js-packages-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/js-packages-plugin@1138

@code-pushup/jsdocs-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/jsdocs-plugin@1138

@code-pushup/lighthouse-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/lighthouse-plugin@1138

@code-pushup/typescript-plugin

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/typescript-plugin@1138

@code-pushup/utils

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/utils@1138

@code-pushup/models-transformers

npm i https://pkg.pr.new/code-pushup/cli/@code-pushup/models-transformers@1138

commit: bd99373

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025 •
edited
Loading

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 7d5d770 with previous commit 9876d94.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Documentation 🔴 36 🔴 34 ↓ −1.5
Performance 🔴 34 🔴 35 ↑ +1.3
Code coverage 🟡 88 🟡 88 ↓ −0.1
Security 🟡 56 🟡 56 –
Updates 🟡 73 🟡 73 –
Accessibility 🟢 92 🟢 92 –
Best Practices 🟢 100 🟢 100 –
SEO 🟡 61 🟡 61 –
Type Safety 🟢 100 🟢 100 –
Bug prevention 🟢 100 🟢 100 –
Miscellaneous 🟢 100 🟢 100 –
Code style 🟢 100 🟢 100 –
👍 1 group improved, 👎 2 groups regressed, 👍 5 audits improved, 👎 4 audits regressed, 12 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
JSDoc coverage Documentation coverage 🔴 36 🔴 34 ↓ −1.5
Lighthouse Performance 🔴 34 🔴 35 ↑ +1.3
Code coverage Code coverage metrics 🟡 88 🟡 88 ↓ −0.1

18 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Initial server response time was short 🟥 Root document took 690 ms 🟩 Root document took 540 ms ↓ −22 %
JSDoc coverage Types coverage 🟥 242 undocumented types 🟥 294 undocumented types ↑ +21.5 %
Lighthouse Speed Index 🟥 7.1 s 🟥 6.7 s ↓ −5.7 %
Lighthouse First Contentful Paint 🟥 3.4 s 🟥 3.2 s ↓ −5.1 %
Lighthouse Total Blocking Time 🟥 2,060 ms 🟥 1,910 ms ↓ −7.3 %
Code coverage Function coverage 🟨 89.4 % 🟨 89.3 % ↓ −0.2 %
Code coverage Branch coverage 🟨 86.5 % 🟨 86.5 % ↓ −0.1 %
Code coverage Line coverage 🟨 84.5 % 🟨 84.5 % ↓ −0.1 %
JSDoc coverage Functions coverage 🟥 524 undocumented functions 🟥 523 undocumented functions ↓ −0.2 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 2,047 KiB 🟩 Total size was 2,060 KiB ↑ +0.6 %
Lighthouse Server Backend Latencies 🟩 120 ms 🟩 810 ms ↑ +554.6 %
Lighthouse Largest Contentful Paint 🟥 10.9 s 🟥 11.3 s ↑ +4.2 %
Lighthouse Max Potential First Input Delay 🟥 1,140 ms 🟥 1,480 ms ↑ +29.5 %
Lighthouse Uses efficient cache policy on static assets 🟨 30 resources found 🟨 30 resources found ↑ +0.1 %
Lighthouse Reduce unused JavaScript 🟥 Potential savings of 180 KiB 🟥 Potential savings of 180 KiB ↑ +21.8 %
Lighthouse JavaScript execution time 🟥 5.3 s 🟥 5.4 s ↑ +3.2 %
Lighthouse Remove duplicate modules in JavaScript bundles 🟥 Potential savings of 105 KiB 🟥 Potential savings of 105 KiB ↑ +51.6 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −0.3 %
Lighthouse Time to Interactive 🟥 13.3 s 🟥 13.2 s ↓ −0.3 %
Lighthouse Network Round Trip Times 🟩 60 ms 🟩 30 ms ↓ −47.3 %
Lighthouse Minimizes main-thread work 🟥 12.7 s 🟥 12.7 s ↓ −0.1 %

589 other audits are unchanged.

@matejchalk matejchalk marked this pull request as ready for review November 7, 2025 15:49
@matejchalk matejchalk mentioned this pull request Nov 7, 2025
Merged
hanna-skryl
hanna-skryl approved these changes Nov 7, 2025
View reviewed changes
Copy link
Collaborator

@hanna-skryl hanna-skryl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much cleaner 👍

BioPhoton
BioPhoton approved these changes Nov 9, 2025
View reviewed changes
Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup! I added a question for the remaining usage of @poppinss/cliui.

@matejchalk matejchalk merged commit 83b9b7b into main Nov 10, 2025
21 checks passed
@matejchalk matejchalk deleted the logger-in-core branch November 10, 2025 07:22
@matejchalk matejchalk mentioned this pull request Nov 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vmasek vmasek vmasek approved these changes

@BioPhoton BioPhoton BioPhoton approved these changes

@hanna-skryl hanna-skryl hanna-skryl approved these changes

Assignees

@matejchalk matejchalk

Labels

🧩 cli 🧩 core 🔬 testing writing tests 🧩 utils

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@matejchalk @vmasek @BioPhoton @hanna-skryl